Use GitHub Actions as the CI #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move away from Semaphore and use GitHub Actions as our CI for this project. Semaphore doesn't have Python 12 yet for us to test against, it will update versions once a month, and with GitHub Actions we can run it on the CI today. [skip changeset]
|
This will need some more work, like:
But this PR is here to gauge our interest. |
|
I am certainly interested! I think this can replace our Semaphore usage as-is. Before merging this we should actually see the checks fail as well as succeed. I don't trust it being green unless I have also seen it being red. |
Run the build every Monday through Friday.
unflxw
approved these changes
Jan 11, 2024
|
@unflxw here's an example with a failure: https://github.com/appsignal/appsignal-python/actions/runs/7492027115 And yes to the Semaphore removal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from Semaphore and use GitHub Actions as our CI for this project.
Semaphore doesn't have Python 12 yet for us to test against, it will update versions once a month, and with GitHub Actions we can run it on the CI today.
[skip changeset]